linux-kernel - Re: [PATCH 0/7] overlay filesystem v9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110520124339.GS3702@shadowen.org>
Date:	Fri, 20 May 2011 13:43:39 +0100
From:	Andy Whitcroft <apw@...onical.com>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	NeilBrown <neilb@...e.de>, viro@...IV.linux.org.uk,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, nbd@...nwrt.org, hramrach@...trum.cz,
	jordipujolp@...il.com
Subject: Re: [PATCH 0/7] overlay filesystem v9

On Fri, May 20, 2011 at 10:18:30AM +0200, Miklos Szeredi wrote:

> Yeah, it should probably do something like:
> 
> 	if (inode->i_op->getattr) {
> 		struct kstat stat;
> 		inode->i_op->getattr(...)
> 		uid = stat.uid;
> 	} else {
> 		uid = inode->i_uid;
> 	}
> 
> The problem is that getattr takes a vfsmount, which makes this
> impossible to do cleanly.  And the solution is for ->getattr() to lose
> that argument, which is a bit more involved :(

Ok.  I am going to take this as a bug in the LSM, so ignore my patch
here.  I have been poking at what the LSM is doing and actually I think
I see the flaw, so I will take the issue up with them.

In light of that take this as a "tested heavily and it worked without
issues" on the V9 version.

Tested-by: Andy Whitcroft <apw@...onical.com>

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/