linux-kernel - Re: [PATCH]: Fix Ultrastor asm snippet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110520130417.GO5077@const.bordeaux.inria.fr>
Date:	Fri, 20 May 2011 15:04:17 +0200
From:	Samuel Thibault <samuel.thibault@...-lyon.org>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	James.Bottomley@...e.de, linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH]: Fix Ultrastor asm snippet

Christoph Hellwig, le Fri 20 May 2011 09:02:15 -0400, a écrit :
> On Wed, May 18, 2011 at 05:06:05PM +0200, Samuel Thibault wrote:
> > Commit 1292500b replaced
> > 
> > "=m" (*field) : "1" (*field)
> > 
> > with
> > 
> > "=m" (*field) :
> > 
> > with comment "The following patch fixes it by using the '+' operator on
> > the (*field) operand, marking it as read-write to gcc."
> > '+' was actually forgotten.  This really puts it.
> 
> Do you actually have the hardware or was this just a code audit?

Just a code audit.

> I have the strong suspicion that this driver is pretty much dead and
> bitrotting.

Most probably, yes.

Samuel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/