linux-kernel - Re: [PATCH 1/8] mm: Kill set but not used var in bdi_debug_stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DD6BF94.7000902@fusionio.com>
Date:	Fri, 20 May 2011 21:23:00 +0200
From:	Jens Axboe <jaxboe@...ionio.com>
To:	"Gustavo F. Padovan" <padovan@...fusion.mobi>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Christoph Hellwig <hch@....de>,
	Artem Bityutskiy <Artem.Bityutskiy@...ia.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Dave Chinner <dchinner@...hat.com>, open list:
	MEMORY MANAGEMENT <linux-mm@...ck.org>, ;
Subject: Re: [PATCH 1/8] mm: Kill set but not used var in  bdi_debug_stats_show()

On 2011-05-20 21:12, Gustavo F. Padovan wrote:
> Signed-off-by: Gustavo F. Padovan <padovan@...fusion.mobi>
> ---
>  mm/backing-dev.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/backing-dev.c b/mm/backing-dev.c
> index befc875..f032e6e 100644
> --- a/mm/backing-dev.c
> +++ b/mm/backing-dev.c
> @@ -63,10 +63,10 @@ static int bdi_debug_stats_show(struct seq_file *m, void *v)
>  	unsigned long background_thresh;
>  	unsigned long dirty_thresh;
>  	unsigned long bdi_thresh;
> -	unsigned long nr_dirty, nr_io, nr_more_io, nr_wb;
> +	unsigned long nr_dirty, nr_io, nr_more_io;
>  	struct inode *inode;
>  
> -	nr_wb = nr_dirty = nr_io = nr_more_io = 0;
> +	nr_dirty = nr_io = nr_more_io = 0;
>  	spin_lock(&inode_wb_list_lock);
>  	list_for_each_entry(inode, &wb->b_dirty, i_wb_list)
>  		nr_dirty++;

Good catch, nr_wb should have been killed with the removal of the worker
list. I'll queue this up.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/