linux-kernel - Re: PATCH: powerpc: remove unused variable assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4DD6CFB9.6090101@ece.ntua.gr>
Date:	Fri, 20 May 2011 23:31:53 +0300
From:	Stratos Psomadakis <psomas@....ntua.gr>
To:	Marcus Meissner <meissner@...e.de>
CC:	benh@...nel.crashing.org, paulus@...ba.org,
	akpm@...ux-foundation.org, linuxppc-dev@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org
Subject: Re: PATCH: powerpc: remove unused variable assignment

On 05/20/2011 12:13 PM, Marcus Meissner wrote:
> Hi,
>
> gcc 4.6 with -Werror does not like setting but not using variables
> anymore.
>
> So remove it, it does not seem necessary.
>
> Signed-off-by: Marcus Meissner <meissner@...e.de>
>
> Ciao, Marcus
> ---
>  arch/powerpc/include/asm/pgtable-ppc64.h |    8 ++------
>  1 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/pgtable-ppc64.h b/arch/powerpc/include/asm/pgtable-ppc64.h
> index 2b09cd5..c3d39de 100644
> --- a/arch/powerpc/include/asm/pgtable-ppc64.h
> +++ b/arch/powerpc/include/asm/pgtable-ppc64.h
> @@ -257,21 +257,17 @@ static inline int __ptep_test_and_clear_young(struct mm_struct *mm,
>  static inline void ptep_set_wrprotect(struct mm_struct *mm, unsigned long addr,
>  				      pte_t *ptep)
>  {
> -	unsigned long old;
> -
>         	if ((pte_val(*ptep) & _PAGE_RW) == 0)
>         		return;
> -	old = pte_update(mm, addr, ptep, _PAGE_RW, 0);
> +	pte_update(mm, addr, ptep, _PAGE_RW, 0);
>  }
>  
>  static inline void huge_ptep_set_wrprotect(struct mm_struct *mm,
>  					   unsigned long addr, pte_t *ptep)
>  {
> -	unsigned long old;
> -
>  	if ((pte_val(*ptep) & _PAGE_RW) == 0)
>  		return;
> -	old = pte_update(mm, addr, ptep, _PAGE_RW, 1);
> +	pte_update(mm, addr, ptep, _PAGE_RW, 1);
>  }
>  
>  /*
It's already in the ppc repo [1]. And going to be merged in 2.6.40 I
think. :)

[1]
http://git.kernel.org/?p=linux/kernel/git/benh/powerpc.git;a=commit;h=2a2c29c1a581319f4485af55e8d628d89e8f2583


-- 
Stratos Psomadakis
<psomas@....ntua.gr>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/