linux-kernel - Re: [PATCH -tip] rcu: use kthread_create_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110520232333.GO2366@linux.vnet.ibm.com>
Date:	Fri, 20 May 2011 16:23:33 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Tejun Heo <tj@...nel.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <ak@...ux.intel.com>, Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH -tip] rcu: use kthread_create_on_node()

On Thu, May 19, 2011 at 10:32:45AM +0200, Eric Dumazet wrote:
> Commit a26ac2455ffc (move TREE_RCU from softirq to kthread) added
> creation of per cpu kthreads.
> 
> Use kthread_create_on_node() NUMA friendly function, to let these
> threads use local node for their stack/task struct.
> 
> We did a similar change in commit 94dcf29a11b3 (kthread: use
> kthread_create_on_node())
> 
> Also change rcu torture kthread creation.

Queued, thank you, Eric!

							Thanx, Paul

> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> CC: Tejun Heo <tj@...nel.org>
> CC: Rusty Russell <rusty@...tcorp.com.au>
> CC: Andrew Morton <akpm@...ux-foundation.org>
> CC: Andi Kleen <ak@...ux.intel.com>
> CC: Ingo Molnar <mingo@...e.hu>
> ---
>  kernel/rcutorture.c |    3 ++-
>  kernel/rcutree.c    |    5 ++++-
>  2 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/rcutorture.c b/kernel/rcutorture.c
> index 2e138db..40d9ed2 100644
> --- a/kernel/rcutorture.c
> +++ b/kernel/rcutorture.c
> @@ -1282,7 +1282,8 @@ static int rcutorture_booster_init(int cpu)
>  	/* Don't allow time recalculation while creating a new task. */
>  	mutex_lock(&boost_mutex);
>  	VERBOSE_PRINTK_STRING("Creating rcu_torture_boost task");
> -	boost_tasks[cpu] = kthread_create(rcu_torture_boost, NULL,
> +	boost_tasks[cpu] = kthread_create_on_node(rcu_torture_boost, NULL,
> +						  cpu_to_node(cpu),
>  					  "rcu_torture_boost");
>  	if (IS_ERR(boost_tasks[cpu])) {
>  		retval = PTR_ERR(boost_tasks[cpu]);
> diff --git a/kernel/rcutree.c b/kernel/rcutree.c
> index 5616b17..b013915 100644
> --- a/kernel/rcutree.c
> +++ b/kernel/rcutree.c
> @@ -1649,7 +1649,10 @@ static int __cpuinit rcu_spawn_one_cpu_kthread(int cpu)
>  	if (!rcu_kthreads_spawnable ||
>  	    per_cpu(rcu_cpu_kthread_task, cpu) != NULL)
>  		return 0;
> -	t = kthread_create(rcu_cpu_kthread, (void *)(long)cpu, "rcuc%d", cpu);
> +	t = kthread_create_on_node(rcu_cpu_kthread,
> +				   (void *)(long)cpu,
> +				   cpu_to_node(cpu),
> +				   "rcuc%d", cpu);
>  	if (IS_ERR(t))
>  		return PTR_ERR(t);
>  	kthread_bind(t, cpu);
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/