lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 20 May 2011 11:15:16 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: linux-next: build failure in Linus' tree

Hi Linus,

With just Linus' tree, today's linux-next build (powerpc ppc64_defconfig)
failed like this:

In file included from arch/powerpc/mm/fault.c:18:
include/linux/signal.h:239: error: 'struct task_struct' declared inside parameter list
include/linux/signal.h:239: error: its scope is only this definition or declaration, which is probably not what you want
include/linux/signal.h:240: error: 'struct task_struct' declared inside parameter list
include/linux/signal.h:241: error: 'struct task_struct' declared inside parameter list
include/linux/signal.h:250: error: 'struct task_struct' declared inside parameter list
include/linux/signal.h:254: error: 'struct task_struct' declared inside parameter list
cc1: warnings being treated as errors

and so on ...

reverting commit e66eed651fd1 ("list: remove prefetching from regular
list iterators").  This is, of course, why we like to put stuff into
linux-next before it goes into your tree :-)

I have applied this patch for today:

From: Stephen Rothwell <sfr@...b.auug.org.au>
Date: Fri, 20 May 2011 11:11:53 +1000
Subject: [PATCH] signal.h need a definition of struct task_struct

fixes these build errors on powerpc:

In file included from arch/powerpc/mm/fault.c:18:
include/linux/signal.h:239: error: 'struct task_struct' declared inside parameter list
include/linux/signal.h:239: error: its scope is only this definition or declaration, which is probably not what you want
include/linux/signal.h:240: error: 'struct task_struct' declared inside parameter list
include/linux/signal.h:241: error: 'struct task_struct' declared inside parameter list
include/linux/signal.h:250: error: 'struct task_struct' declared inside parameter list
include/linux/signal.h:254: error: 'struct task_struct' declared inside parameter list
cc1: warnings being treated as errors

Exposed by commit e66eed651fd1 ("list: remove prefetching from regular
list iterators").

Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
---
 include/linux/signal.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/linux/signal.h b/include/linux/signal.h
index fcd2b14..29a68ac 100644
--- a/include/linux/signal.h
+++ b/include/linux/signal.h
@@ -7,6 +7,8 @@
 #ifdef __KERNEL__
 #include <linux/list.h>
 
+struct task_struct;
+
 /* for sysctl */
 extern int print_fatal_signals;
 /*
-- 
1.7.5.1

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists