linux-kernel - Re: [PATCH 5/7] overlay filesystem (inode.c bad error path)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <B61DE78E-D7DB-4EB3-B8B3-64912D8BB212@fsl.cs.sunysb.edu>
Date:	Sat, 21 May 2011 01:15:46 -0400
From:	Erez Zadok <ezk@....cs.sunysb.edu>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	"viro@...IV.linux.org.uk" <viro@...IV.linux.org.uk>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"apw@...onical.com" <apw@...onical.com>,
	"nbd@...nwrt.org" <nbd@...nwrt.org>,
	"neilb@...e.de" <neilb@...e.de>,
	"hramrach@...trum.cz" <hramrach@...trum.cz>,
	"jordipujolp@...il.com" <jordipujolp@...il.com>
Subject: Re: [PATCH 5/7] overlay filesystem (inode.c bad error path)

On May 20, 2011, at 10:25 AM, Miklos Szeredi wrote:

> Erez Zadok <ezk@....cs.sunysb.edu> writes:
>> Niklos, I forgot to mention that I had to apply a small fix to a VFS
>> bug in fs/namei.c:1362, where a mix of symlinks and renames, using
>> racer, triggers an BUG_ON at the VFS layer (very reproducible).
>> Without this fix, racer oopses in the VFS well before it gets to
>> trigger overlayfs bugs.  It's a pity 2.6.39 was released with this
>> very reproducible *VFS* level bug (doesn't anyone run racer+fsx+ltp
>> before releasing a new kernel?)
>> 
>> Anyway, here's the small patch here.  Clearly viro/hch need to review
>> this "fix" b/c I'm not sure it's really the right one
> 
> Patch looks good to me.
> 
> Acked-by: Miklos Szeredi <mszeredi@...e.cz>
> 
> If you've got a patch fixing a serious bug, you'd better send it to
> Linus and Andrew (as well as the VFS maintainers), where it'll get more
> prompt evaluation.
> 
> You can still do that, also adding "CC: stable@...nel.org" to the SOB
> block in the patch so that the fix quickly makes it into the 2.6.39
> stable series.
> 
> Thanks,
> Miklos

Thanks.  I'll do that.

Erez.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/