linux-kernel - Re: Resume Issues :Exec of NX page, Synaptics Botchup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTimt0ozTCSarTVwkOpvgLoW-pizMvA@mail.gmail.com>
Date:	Sun, 22 May 2011 16:43:07 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Parag Warudkar <parag.lkml@...il.com>
Cc:	Fenghua Yu <fenghua.yu@...el.com>,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Ingo Molnar <mingo@...e.hu>, Dmitry Torokhov <dtor@...l.ru>,
	linux-kernel@...r.kernel.org
Subject: Re: Resume Issues :Exec of NX page, Synaptics Botchup

On Sun, May 22, 2011 at 3:22 PM, Parag Warudkar <parag.lkml@...il.com> wrote:
>
> Now I get a different call trace for the same NX error. (And Synaptics is
> completely dead this time - not attributable to the patch, it was dumb
> luck perhaps that it wored last time.)

Just because I'm crazy, can you double-check that you applied my patch
and booted the right kernel?

Because that NX error *really* looks like the call to setup_smep(),
and the eip still very much looks like something jumped to the
"__init" region, not the "__cpuinit" region.

That backtrace really still looks like the same thing.

Oh, and you should do

-static int disable_smep __initdata;
+static int disable_smep __cpuinitdata;

too, I guess. Not that it should matter for this particular oops.

                 Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/