linux-kernel - Re: [PATCH] arch/tile: add arch/tile/drivers/ directory with SROM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTik-d3ip3R42=fRyjFav2SeXfki=ng@mail.gmail.com>
Date:	Sat, 21 May 2011 17:54:17 -0700
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Eric Biederman <ebiederm@...stanetworks.com>,
	Chris Metcalf <cmetcalf@...era.com>,
	linux-kernel@...r.kernel.org, Chris Wright <chrisw@...s-sol.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Benjamin Thery <benjamin.thery@...l.net>,
	Phil Carmody <ext-phil.2.carmody@...ia.com>
Subject: Re: [PATCH] arch/tile: add arch/tile/drivers/ directory with SROM driver

On Sat, May 21, 2011 at 01:32, Arnd Bergmann wrote:
> On Saturday 21 May 2011 09:46:55 Eric Biederman wrote:
>> What is wrong with an mtd driver?
>>
>> Looking a bit back into the conversation it appears clear that you are
>> talking about something that resembles NOR flash with multiple sectors,
>> etc.
>>
>> eeproms have random byte access and are typically 256 bytes.  You devices
>> doesn't sound anything like an eeprom.
>
> MTD implies that you have low-level access to the NOR flash registers,
> which this one doesn't. It's certainly not the right Linux interface
> for a high-level flash device, and there is no precedent for this at
> all in Linux.
>
> We do have precedent for multiple interfaces that have the same
> purpose as this one:
>
> drivers/misc/eeprom/*
> drivers/char/ps3flash.c
> drivers/char/nwflash.c
> drivers/char/bfin-otp.c

there is a new otp framework in the works that this driver would move
to.  but that wouldnt matter to the driver being proposed for the tile
arch i dont think.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/