linux-kernel - Re: [PATCH 2/3] perf_events: fix validation of events using an extra reg (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BANLkTi=m+kaRfMzFh7-p8E+YJC_O+Ja6cw@mail.gmail.com>
Date:	Mon, 23 May 2011 11:15:05 +0200
From:	Stephane Eranian <eranian@...gle.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	"mingo@...e.hu" <mingo@...e.hu>, Andi Kleen <andi@...stfloor.org>,
	Lin Ming <ming.m.lin@...el.com>
Subject: Re: [PATCH 2/3] perf_events: fix validation of events using an extra
 reg (v2)

On Mon, May 23, 2011 at 9:47 AM, Peter Zijlstra <peterz@...radead.org> wrote:
> On Fri, 2011-05-20 at 18:45 +0200, Stephane Eranian wrote:
>> On Fri, May 20, 2011 at 5:05 PM, Peter Zijlstra <peterz@...radead.org> wrote:
>> > On Fri, 2011-05-20 at 16:37 +0200, Stephane Eranian wrote:
>> >> The is_fake field is necessary to avoid a lockdep issue having
>> >> to do with interrupt masking and era->lock.
>> >
>> > Why not simply disable IRQs in both validate_* functions?
>> >
>> Could do that too if you think that's cleaner.
>
> Its saner than making that code path conditional, but an alternative
> solution is to give the fake thing a different lock class.
>
Looks like using irqsave()/irqrestore() would be easier. Let me respin
the patch series for this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/