linux-kernel - Re: ramoops: is using platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTi=iGzkSwWPZrFPBJZYg6x=dDBb5Eg@mail.gmail.com>
Date:	Mon, 23 May 2011 22:10:17 +0800
From:	Américo Wang <xiyou.wangcong@...il.com>
To:	Stevie Trujillo <stevie.trujillo@...il.com>
Cc:	marco.stornelli@...il.com, linux-kernel@...r.kernel.org,
	Kyungmin Park <kyungmin.park@...sung.com>
Subject: Re: ramoops: is using platform_drivers correct?

On Mon, May 23, 2011 at 9:27 PM, Stevie Trujillo
<stevie.trujillo@...il.com> wrote:
> Hello,
>
> ramoops (drivers/char/ramoops.c) is for "all" computers right? When I try to
> load it on my laptop, I get ENODEV. This is caused by platform_driver_probe()
> - the code never reaches the ramoops probe callback.
>
> After I removed the platform_driver stuff, moving everything into ramoops_init
> and ramoops_exit it worked.

Actually that was changed by Kyungmin, Cc'ing...

commit c3b92ce9e75f6353104fc7f8e32fb9fdb2550ad0
Author: Kyungmin Park <kyungmin.park@...sung.com>
Date:   Wed Oct 27 15:34:52 2010 -0700

    ramoops: use the platform data structure instead of module params

    As each board and system has different memory for ramoops.  It's better to
    define the platform data instead of module params.

    [akpm@...ux-foundation.org: fix ramoops_remove() return type]
    Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
    Cc: Marco Stornelli <marco.stornelli@...il.com>
    Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/