linux-kernel - Re: [PATCH 1/3] do collectcfiles work in perl itself, eschew shell pipeline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 22 May 2011 19:16:17 -0700
From:	"Randy Dunlap" <rdunlap@...otime.net>
To:	"Jim Cromie" <jim.cromie@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
	"Jim Cromie" <jim.cromie@...il.com>
Subject: Re: [PATCH 1/3] do collectcfiles work in perl itself, eschew shell
 pipeline

On Sat, May 21, 2011 1:21 am, Jim Cromie wrote:

>  sub collectcfiles {
> -    my @file
> -	= `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed s/\.ko$/.mod.c/`;
> +    my @file;
> +    while (<.tmp_versions/*.mod>) {
> +	open my $fh, '<', $_ or die "cant open $_: $!\n";

Use either "can't" or "cannot".  "cant" is a different word.

> +	push (@file,
> +	      grep s/\.ko/.mod.c/,	# change the suffix
> +	      grep m/.+\.ko/,		# find the .ko path
> +	      <$fh>);			# lines in opened file
> +    }
>      chomp @file;
>      return @file;
>  }


-- 
~Randy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/