linux-kernel - Re: [patch v3] checkpatch: Signature format verification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1306167105.8687.11.camel@Joe-Laptop>
Date:	Mon, 23 May 2011 09:11:45 -0700
From:	Joe Perches <joe@...ches.com>
To:	anish <anish198519851985@...il.com>
Cc:	davej@...hat.com, rostedt@...dmis.org, apw@...dowen.org,
	akpm@...ux-foundation.org, vapier@...too.org,
	linux-kernel@...r.kernel.org, man.k1983@...il.com
Subject: Re: [patch v3] checkpatch: Signature format verification

On Mon, 2011-05-23 at 20:51 +0530, anish wrote:
> From: anish kumar <anish198519851985@...il.com>
> This patch generates warning when there is no space between
> the patch submitter and successive mail-id.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> +				if (!($line =~ /^\s*$sign/)) {

				if  ($line !~ /etc...)

> +					WARN("$sign is the preferred form\n" .
> +						$herecurr);
> +				}
> +				if ($line =~ /^\s*$sign(.*)/i) {
> +					if($1 !~ /^\s*(\s[a-zA-Z]*.*)/i) {

Email addresses may start with a quote (") or a digit.

Space between if and (

> +						WARN("Space required after $sign\n" .
> +							$herecurr);
> +					}
> +					if($1 !~ /[\sa-zA-Z]+\s<.*>/i) {

Space between if and (


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/