linux-kernel - Re: [patch v3] checkpatch: Signature format verification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20110523100755.9e77d043.rdunlap@xenotime.net>
Date:	Mon, 23 May 2011 10:07:55 -0700
From:	Randy Dunlap <rdunlap@...otime.net>
To:	anish singh <anish198519851985@...il.com>
Cc:	Joe Perches <joe@...ches.com>, davej@...hat.com,
	rostedt@...dmis.org, apw@...dowen.org, akpm@...ux-foundation.org,
	vapier@...too.org, linux-kernel@...r.kernel.org,
	man.k1983@...il.com
Subject: Re: [patch v3] checkpatch: Signature format verification

On Mon, 23 May 2011 22:36:12 +0530 anish singh wrote:

> On Mon, May 23, 2011 at 10:12 PM, Joe Perches <joe@...ches.com> wrote:
> 
> > On Mon, 2011-05-23 at 09:39 -0700, Randy Dunlap wrote:
> > > On Mon, 23 May 2011 09:36:38 -0700 Joe Perches wrote:
> > > > On Mon, 2011-05-23 at 22:03 +0530, anish singh wrote:
> > > > > \s[a-zA-Z]* => this is a regular expression for name & space b/w
> > > > > Last/First name
> > > > >                     Ex: anish kumar
> > > > > .* => It is used to grep whatever follows name...in our context
> > > > > mail-id
> > > > >         Ex: abc@....com.
> > > > > So, $1 will contain ...'anish kumar <anish@...il.com>'
> > > > Unless the email contains a quote or a period like:
> > > > Signed-off-by: "J. Random Contributor" <jrc@...ain.tld>
> > > and quotes are not required (i.e., are optional) AFAIK.
> >
> > And still should be accepted.
> >
> if ($1 !~ /^\s+([a-zA-Z\s\"]*.*)/i) {
>             WARN("Space required after $sign\n" .
>             $herecurr);
>   }
>  if ($1 !~ /[\sa-zA-Z\"]*\s<.*>/i) {
>  WARN("Space required b/w Full Name & Mail-id:\n" .

"b/w" is not a good abbreviation (for "between" ???).

>                                                         $herecurr);
>                                         }
> Qoute has been taken care too now.


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/