linux-kernel - Re: [PATCH -next] x86: apic_flat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DDAA2C0.7080108@gmail.com>
Date:	Mon, 23 May 2011 22:09:04 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
CC:	Stephen Rothwell <sfr@...b.auug.org.au>, x86@...nel.org,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>,
	Suresh Siddha <suresh.b.siddha@...el.com>
Subject: Re: [PATCH -next] x86: apic_flat_64.c needs module.h

On 05/23/2011 09:51 PM, Cyrill Gorcunov wrote:
> On 05/23/2011 09:43 PM, Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap@...cle.com>
>>
>> apic_flat_64.c needs to include module.h to fix these warnings:
>>
>> arch/x86/kernel/apic/apic_flat_64.c:31: warning: data definition has no type or storage class
>> arch/x86/kernel/apic/apic_flat_64.c:31: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
>> arch/x86/kernel/apic/apic_flat_64.c:31: warning: parameter names (without types) in function declaration
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
>> ---
>>  arch/x86/kernel/apic/apic_flat_64.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> --- linux-next-20110523.orig/arch/x86/kernel/apic/apic_flat_64.c
>> +++ linux-next-20110523/arch/x86/kernel/apic/apic_flat_64.c
>> @@ -16,6 +16,7 @@
>>  #include <linux/ctype.h>
>>  #include <linux/init.h>
>>  #include <linux/hardirq.h>
>> +#include <linux/module.h>
>>  #include <asm/smp.h>
>>  #include <asm/apic.h>
>>  #include <asm/ipi.h>
> 
> Thanks Randy! For some reason I didn't hit this problem while
> were compiling the kernel and testing it (I usually do not use
> modules though).
> 
> I've CC'ed Ingo and Suresh.
> 

Randy, while adding module.h here is correct I fail to see why I didn't
hit this problem before, could you please post your config?

-- 
    Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/