lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110523184233.GA26835@infradead.org>
Date:	Mon, 23 May 2011 14:42:34 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	"K. Y. Srinivasan" <kys@...rosoft.com>
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org,
	devel@...uxdriverproject.org, tglx@...utronix.de,
	johnstul@...ibm.com, hch@...radead.org,
	Hank Janssen <hjanssen@...rosoft.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>
Subject: Re: [PATCH 1/1] Clocksource: Move the Hyper-V clocksource driver out
 of staging

> +#include <linux/version.h>

This one shouldn't be needed.

> +#include <asm/hyperv.h>
> +#include <asm/mshyperv.h>

not really a review for this driver, but what's the purpose if having
these two headers?

Shouldn't the Kconfig entry also move from drivers/staging to
arch/x86 towards the other clocksources?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ