linux-kernel - RE: [PATCH 1/1] Clocksource: Move the Hyper-V clocksource driver out of staging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6E21E5352C11B742B20C142EB499E0481FC8F8@TK5EX14MBXC122.redmond.corp.microsoft.com>
Date:	Mon, 23 May 2011 19:05:22 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	Christoph Hellwig <hch@...radead.org>
CC:	"gregkh@...e.de" <gregkh@...e.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"johnstul@...ibm.com" <johnstul@...ibm.com>,
	Hank Janssen <hjanssen@...rosoft.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>
Subject: RE: [PATCH 1/1] Clocksource: Move the Hyper-V clocksource driver
 out of staging



> -----Original Message-----
> From: Christoph Hellwig [mailto:hch@...radead.org]
> Sent: Monday, May 23, 2011 2:43 PM
> To: KY Srinivasan
> Cc: gregkh@...e.de; linux-kernel@...r.kernel.org;
> devel@...uxdriverproject.org; tglx@...utronix.de; johnstul@...ibm.com;
> hch@...radead.org; Hank Janssen; Haiyang Zhang
> Subject: Re: [PATCH 1/1] Clocksource: Move the Hyper-V clocksource driver out
> of staging
> 
> > +#include <linux/version.h>
> 
> This one shouldn't be needed.

Correct; I will fix this.
> 
> > +#include <asm/hyperv.h>
> > +#include <asm/mshyperv.h>
> 
> not really a review for this driver, but what's the purpose if having
> these two headers?

These header files have the defines for checking if we are running on 
Hyper-V.

> 
> Shouldn't the Kconfig entry also move from drivers/staging to
> arch/x86 towards the other clocksources?

Currently this driver is built if  HYPERV is defined. I agree with you
that I should have Kconfig entry in arch/x86. Since the rest of the 
Hyper-V drivers are still in staging, I am thinking that perhaps we should 
have a different config switch - HYPERV_CLKSRC. I will go ahead and 
spin a new version of this patch with this change.

Regards,

K. Y
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/