linux-kernel - Re: [PATCH] kernel: Fix ftrace.c compiler warning when calling ftrace_nop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4DDABDF2.1080704@zytor.com>
Date:	Mon, 23 May 2011 13:05:06 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	John Kacur <jkacur@...hat.com>
CC:	Steven Rostedt <rostedt@...dmis.org>,
	Eduardo Silva <edsiper@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel: Fix ftrace.c compiler warning when calling ftrace_nop_replace()

On 05/23/2011 01:01 PM, John Kacur wrote:
> On Mon, 23 May 2011, Steven Rostedt wrote:
>> The real solution is to change all the users into const *. This should
>> be doable as the new and old pointers are not modified.


> 
> From 71d6e5971cc90a03fd2d7bf8aaa2b81932bd0c7c Mon Sep 17 00:00:00 2001
> From: John Kacur <jkacur@...hat.com>
> Date: Mon, 23 May 2011 21:24:27 +0200
> Subject: [PATCH] ftrace: Change unsigned char *new, *old to const
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> This removes the warning:
> arch/x86/kernel/ftrace.c: In function ‘ftrace_make_nop’:
> /arch/x86/kernel/ftrace.c:308: warning: assignment discards qualifiers from pointer target type
> 
> Steven Rostedt suggested to make these pointers const pointers.
> 
> This patch assumes that
> https://patchwork.kernel.org/patch/798172/
> is applied first.
> 
> Reported-by: Eduardo Silva <edsiper@...il.com>
> Signed-off-by: John Kacur <jkacur@...hat.com>

Looks much better.

Acked-by: H. Peter Anvin <hpa@...or.com>

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/