linux-kernel - Re: [PATCH] um: use RWSEM_GENERIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 23 May 2011 13:46:30 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Richard Weinberger <richard@....at>
Cc:	akpm@...ux-foundation.org,
	user-mode-linux-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	"# .39.x" <stable@...nel.org>
Subject: Re: [PATCH] um: use RWSEM_GENERIC_SPINLOCK on x86

On Mon, May 23, 2011 at 1:30 PM, Richard Weinberger <richard@....at> wrote:
>
>  config RWSEM_XCHGADD_ALGORITHM
> -       def_bool X86_XADD
> +       def_bool X86_XADD && 64BIT
>
>  config RWSEM_GENERIC_SPINLOCK
> -       def_bool !X86_XADD
> +       def_bool !X86_XADD || !64BIT

May I suggest just changing that second one to

  config RWSEM_GENERIC_SPINLOCK
      def_bool !RWSEM_XCHGADD_ALGORITHM

because I had to look twice just to make sure that they are inverses
of each other.

So why not make that inverse relationship more obvious?

                         Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/