linux-kernel - Re: [PATCH] Cleanup pc87413 watchdog driver to use request_muxed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 24 May 2011 09:17:24 +0200
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Jonathan McDowell <noodles@...th.li>
Cc:	linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Cleanup pc87413 watchdog driver to use
	request_muxed_region for SuperIO area

Hi Jonathan,

> > I don't think this is the correct way to do this. You do the
> > request_muxed_region only at init and exit of the module.
> 
> I do a single request_muxed_region in the init function, and release it
> at the end of the init function. It's only necessary to hold the LPC
> region while the WDT functionality is enabled and the base address for
> the SWC block is retrieved.
> 
> After that point all access is via the SWC region, so there's no need to
> call request_muxed_region. The call in the exit function releases the
> SWC block. We're not holding the LPC region for the entire duration of
> the driver being loaded.

Added to linux-2.6-watchdog-next.

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/