linux-kernel - Re: [PATCH] pci, dmar: Update dmar units devices list during hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 May 2011 11:58:15 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	Alex Williamson <alex.williamson@...hat.com>
Cc:	Yinghai Lu <yinghai@...nel.org>, Vinod Koul <vinod.koul@...el.com>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	iommu@...ts.linux-foundation.org,
	Dan Williams <dan.j.williams@...el.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] pci, dmar: Update dmar units devices list during hotplug

On Thu, 2011-05-19 at 16:15 -0600, Alex Williamson wrote:
> I think I'd vote for saving some kind of representation of the bus
> hierarchy, we probably don't need to list every possible individual
> device.  Leaving a broken pointer around to be matched up and restored
> later just seems like a continuation of an idea that was bad to begin
> with.  Thanks, 

I agree. We should just process the original ATSR information in
dmar_find_matched_drhd_unit(), rather than comparing with a list of
possibly stale pointers.

I don't quite understand why the list of PCI devices was *ever* done
like that.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@...el.com                              Intel Corporation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/