linux-kernel - Re: [PATCH] sched: remove noop in next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1306238014.16375.0.camel@marge.simson.net>
Date:	Tue, 24 May 2011 13:53:34 +0200
From:	Mike Galbraith <efault@....de>
To:	Yong Zhang <yong.zhang0@...il.com>
Cc:	Hillf Danton <dhillf@...il.com>,
	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <peterz@...radead.org>,
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH] sched: remove noop in next_prio()

On Tue, 2011-05-24 at 16:17 +0800, Yong Zhang wrote:
> On Sat, May 21, 2011 at 10:19 PM, Hillf Danton <dhillf@...il.com> wrote:
> > When computing the next priority for a given run-queue, the check for
> > RT priority of the task determined by the pick_next_highest_task_rt()
> > function could be removed, since only RT task is returned by the
> > function.
> >
> > Signed-off-by: Hillf Danton <dhillf@...il.com>
> 
> Yup, it's true.

(could whack the else while there)

> Reviewed-by: Yong Zhang <yong.zhang0@...il.com>
> 
> > ---
> >
> > --- a/kernel/sched_rt.c 2011-04-27 11:48:50.000000000 +0800
> > +++ b/kernel/sched_rt.c 2011-05-21 22:10:34.000000000 +0800
> > @@ -670,7 +670,7 @@ static inline int next_prio(struct rq *r
> >  {
> >        struct task_struct *next = pick_next_highest_task_rt(rq, rq->cpu);
> >
> > -       if (next && rt_prio(next->prio))
> > +       if (next)
> >                return next->prio;
> >        else
> >                return MAX_RT_PRIO;
> >
> 
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/