linux-kernel - Re: [PATCH] TTY: export NR_LDISC and N_* line discipline numbers to user-space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110524124044.GD31517@suse.de>
Date:	Tue, 24 May 2011 05:40:44 -0700
From:	Greg KH <gregkh@...e.de>
To:	Florian Fainelli <ffainelli@...ebox.fr>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Maxime Bizon <mbizon@...ebox.fr>
Subject: Re: [PATCH] TTY: export NR_LDISC and N_* line discipline numbers to
 user-space

On Tue, May 24, 2011 at 10:43:03AM +0200, Florian Fainelli wrote:
> From: Florian Fainelli <ffainelli@...ebox.fr>
> 
> Since commit (4564f9e5: consolidate line discipline number definitions)
> the patch moved all line discipline number from a per-architecture termios.h
> to a shared one: tty.h. However, prior to this consolidation work, the
> line discipline numbers were outside of an ifdef __KERNEL__/endif block
> so these numbers used to be exported to user-space.
> 
> Since such numbers are kernel ABI anyway, and tty.h is already included
> for user- space header processing, just move these relevant defines
> outside of the ifdef __KERNEL__/endif block in include/linux/tty.h.

Any reason you didn't copy _any_ of the people who signed off on that
patch, or the original author of that patch?

Anyway, this is been this way for four years, since the 2.6.21 kernel
release.  Since no one has noticed, or complained, since then, how much
a problem is this really?

Meaning, why has it taken this long for anyone to notice?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/