linux-kernel - Re: [PATCH 3/9] [SCSI] lpfc: Silence DEBUG_STRICT_USER_COPY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 May 2011 09:32:47 -0400
From:	James Smart <james.smart@...lex.com>
To:	Stephen Boyd <sboyd@...eaurora.org>
CC:	"James E.J. Bottomley" <James.Bottomley@...e.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"Iannicelli, Alex" <Alex.Iannicelli@...lex.Com>
Subject: Re: [PATCH 3/9] [SCSI] lpfc: Silence DEBUG_STRICT_USER_COPY_CHECKS=y
 warning

Acked-by: James Smart <james.smart@...lex.com>

Thanks

-- james


On 5/12/2011 7:50 PM, Stephen Boyd wrote:
> Enabling DEBUG_STRICT_USER_COPY_CHECKS causes the following
> warning:
>
> In file included from arch/x86/include/asm/uaccess.h:573,
>                   from include/linux/uaccess.h:5,
>                   from include/linux/highmem.h:7,
>                   from include/linux/pagemap.h:10,
>                   from include/linux/blkdev.h:12,
>                   from drivers/scsi/lpfc/lpfc_debugfs.c:21:
> In function 'copy_from_user':
> arch/x86/include/asm/uaccess_64.h:65:
> warning: call to 'copy_from_user_overflow' declared with
> attribute warning: copy_from_user() buffer size is not provably
> correct
>
> presumably due to buf_size being signed causing GCC to fail to
> see that buf_size can't become negative.
>
> Cc: James Smart<james.smart@...lex.com>
> Signed-off-by: Stephen Boyd<sboyd@...eaurora.org>
> ---
>   drivers/scsi/lpfc/lpfc_debugfs.c |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c
> index 3d96774..0af53a6 100644
> --- a/drivers/scsi/lpfc/lpfc_debugfs.c
> +++ b/drivers/scsi/lpfc/lpfc_debugfs.c
> @@ -1305,7 +1305,8 @@ static int lpfc_idiag_cmd_get(const char __user *buf, size_t nbytes,
>   {
>   	char mybuf[64];
>   	char *pbuf, *step_str;
> -	int bsize, i;
> +	int i;
> +	size_t bsize;
>
>   	/* Protect copy from user */
>   	if (!access_ok(VERIFY_READ, buf, nbytes))
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/