[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20110524160847.48ba7d34@absol.kitzblitz>
Date: Tue, 24 May 2011 16:08:47 +0200
From: Nicolas Kaiser <nikai@...ai.net>
To: Richard Cochran <richardcochran@...il.com>
Cc: Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] posix clocks: correct error value in posix_clock_poll()
* Richard Cochran <richardcochran@...il.com>:
> On Tue, May 24, 2011 at 12:51:47PM +0200, Nicolas Kaiser wrote:
> > It looks to me like -ENODEV might not be a good return value
> > in poll(). Would POLLERR be the correct one in this case?
> The condition (!clk) is only satisfied when 'zombie' is set,
> indicating that the dynamic clock has disappeared. That is why the
> file operations uniformly return ENODEV. So, I think it makes sense
> the way that it is.
>
> In addition, man 2 poll says,
>
> POLLERR
> Error condition (output only).
>
> so using that error code would be misleading, IMHO.
I see. Sorry for the noise.
Best regards,
Nicolas Kaiser
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists