linux-kernel - Re: [PATCH 1/2] power: bq20z75: support external notification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1306263520.31129.4.camel@rklein-linux2>
Date:	Tue, 24 May 2011 11:58:40 -0700
From:	Rhyland Klein <rklein@...dia.com>
To:	Anton Vorontsov <cbouatmailru@...il.com>
Cc:	"bleung@...gle.com" <bleung@...gle.com>,
	"olof@...om.net" <olof@...om.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] power: bq20z75: support external notification

On Tue, 2011-05-24 at 11:58 -0700, Anton Vorontsov wrote:
> On Thu, May 19, 2011 at 04:00:03PM -0700, Rhyland Klein wrote:
> [...]
> > +	INIT_DELAYED_WORK(&bq20z75_device->work, bq20z75_delayed_work);
> > +
> > +	bq20z75_device->enable_detection = true;
> 
> Um... I don't follow this part.
> 
> Especially considerting that the next patch just removes this line,
> but says that it "enables detection after registering". Hm.
> 
> It says "need to enable detection" and removes "enable_detection = true".
> 
> Could you explain what's going on here? :-)
> 
> Thanks,
> 

I messed up my patches, sorry about the confusion. The first patch
wasn't supposed to add it and the second was going to do it. Let me
refresh the patches and resend them. Sorry again.

-rhyland


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/