linux-kernel - Re: [PATCH] MIPS:i8259.c remove resume and shutdown to syscore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTimYuJiiCbqO9QxgaAKHAZWe04vhgA@mail.gmail.com>
Date:	Tue, 24 May 2011 21:09:58 +0200
From:	Manuel Lauss <manuel.lauss@...glemail.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	wanlong.gao@...il.com, Ralf Baechle <ralf@...ux-mips.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org,
	Pengfei Zhang <zoppof.zhang@...il.com>,
	Linux PM mailing list <linux-pm@...ts.linux-foundation.org>
Subject: Re: [PATCH] MIPS:i8259.c remove resume and shutdown to syscore_ops

On Tue, May 24, 2011 at 8:59 PM, Rafael J. Wysocki <rjw@...k.pl> wrote:
> On Tuesday, May 24, 2011, Wanlong Gao wrote:
>>
>> > On Tue, May 24, 2011 at 08:19:18PM +0800, Pengfei Zhang wrote:
>> >
>> > > Remove the resume and shutdown of i8259A from the sysdev_class
>> > > to the syscore_ops since these members had removed from the
>> > > structure sysdev_class.
>> >
>> > I don't see why one would want to want to first call
>> > register_syscore_ops
>> > then sysdev_class_register and sysdev_register?
>> >
>> Hi Ralf:
>> If these not moved to syscore_ops, building will get error.
>>
>> Hi Thomas:
>> Does you mean that we can just remove the sysfs entry now ?
>
> I had the appended patch in my tree before the merge window started,
> but it conflicted with analogous changes in the MIPS tree, so I had
> dropped it.  Was it a mistake?
> Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>
> Acked-by: Greg Kroah-Hartman <gregkh@...e.de>
> Acked-and-tested-by: Lars-Peter Clausen <lars@...afoo.de>
> ---
>  arch/mips/alchemy/common/dbdma.c |   92 +++++++++++----------------------------
>  arch/mips/alchemy/common/irq.c   |   62 +++++++++-----------------

I took care of these two, they were the reason for the conflict in -next.

Manuel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/