linux-kernel - Re: [rfc] Ignore Fsync Calls in Laptop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 May 2011 10:00:03 +1000
From:	Dave Chinner <david@...morbit.com>
To:	Oliver Neukum <oneukum@...e.de>
Cc:	"D. Jansen" <d.g.jansen@...glemail.com>,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	tytso@....edu
Subject: Re: [rfc] Ignore Fsync Calls in Laptop_Mode

On Mon, May 23, 2011 at 10:12:06AM +0200, Oliver Neukum wrote:
> Am Sonntag, 22. Mai 2011, 02:48:33 schrieb Dave Chinner:
> > On Fri, May 20, 2011 at 08:01:17AM +0200, D. Jansen wrote:
> > > On Fri, May 20, 2011 at 5:39 AM, Dave Chinner <david@...morbit.com> wrote:
> 
> > > 1. I thought I (may) make that decision by using laptop mode.
> > 
> > Laptop mode does not change fsync guarantees, so no, you ar enot
> > making a decision to throw data away when you select laptop mode.
> 
> You do however decide to sync less often, resulting in a potentially
> larger loss of data.
> 
> > > 3. A lib doesn't fix the ordering guarantee problem.
> > 
> > A properly implemented filesystem will not have ordering problems
> > just because fsyncs are not issued.
> 
> But user space will have this problem. A single task's sequence of
> write(); fsync(); write(); does give an implicit guarantee of ordering
> to user space.

Oh, you're talking about application level write ordering. IO
"ordering" in filesystem speak is about guaranteeing the order of
data vs metadata writes for ensuring consistency after a crash
(e.g. ext3/4 default "data=ordered" mode). that's what I was
refering to, not anythign to do with applications.

Besides, having to work out how to handle subtle application write
ordering bugs because you changed fsync semantics is simply another
reason for not changing behaviour in the first place.

Cheers,

Dave.
-- 
Dave Chinner
david@...morbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/