linux-kernel - Re: pch_gpio: Support new device ML7223

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201105251409.47309.alexander.stein@systec-electronic.com>
Date:	Wed, 25 May 2011 14:09:46 +0200
From:	Alexander Stein <alexander.stein@...tec-electronic.com>
To:	Tomoya <tomoya-linux@....okisemi.com>
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	linux-kernel@...r.kernel.org, qi.wang@...el.com,
	yong.y.wang@...el.com, joel.clark@...el.com,
	kok.howg.ewe@...el.com, toshiharu-linux@....okisemi.com
Subject: Re: pch_gpio: Support new device ML7223

Hello Tomoya,

On Monday 09 May 2011 12:58:49 Tomoya wrote:
> diff --git a/drivers/gpio/pch_gpio.c b/drivers/gpio/pch_gpio.c
> index f970a5f..36919e7 100644
> --- a/drivers/gpio/pch_gpio.c
> +++ b/drivers/gpio/pch_gpio.c
> @@ -283,8 +283,10 @@ static int pch_gpio_resume(struct pci_dev *pdev)
>  #define pch_gpio_resume NULL
>  #endif
> 
> +#define PCI_VENDOR_ID_ROHM             0x10DB

Should this be moved to pci_ids.h?

>  static DEFINE_PCI_DEVICE_TABLE(pch_gpio_pcidev_id) = {
>  	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x8803) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8014) },

Likewise for the product ID. While at it, the ID for EG20T could also be moved 
in a separate patch.

>  	{ 0, }
>  };
>  MODULE_DEVICE_TABLE(pci, pch_gpio_pcidev_id);

Regards,
Alexander
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/