linux-kernel - Re: [PATCH] sched: remove starvation in check_preempt_equal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTin-feweuE_vm_x1Ex8Yr4ezsJ2wKA@mail.gmail.com>
Date:	Wed, 25 May 2011 22:00:03 +0800
From:	Hillf Danton <dhillf@...il.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Mike Galbraith <efault@....de>,
	Yong Zhang <yong.zhang0@...il.com>
Subject: Re: [PATCH] sched: remove starvation in check_preempt_equal_prio()

On Tue, May 24, 2011 at 10:46 PM, Steven Rostedt <rostedt@...dmis.org> wrote:
> On Tue, 2011-05-24 at 22:33 +0800, Hillf Danton wrote:
>> On Tue, May 24, 2011 at 10:24 PM, Steven Rostedt <rostedt@...dmis.org> wrote:
>> > On Tue, 2011-05-24 at 22:01 +0800, Hillf Danton wrote:
>> >> On Tue, May 24, 2011 at 9:47 PM, Peter Zijlstra <peterz@...radead.org> wrote:
>> >> > On Tue, 2011-05-24 at 21:34 +0800, Hillf Danton wrote:
>> >> >> If there are pushable tasks and they are high enough in priority, in which
>> >> >> case task p is covered, the current could keep holding its CPU.
>> >> >
>> >> > -ENOPARSE..
>> >> >
>> >>
>> >> Here the priority is same, then pushing task p off has little difference from
>> >> pushing any other pushable.
>> >
>> > If task p is currently running and is a FIFO task, you do not push it
>> > off for another task of same prio.
>> >
>> If it is one of the current principles in RT schedule, the patch has
>> to be dropped.
>>
>
> Yes, that is the definition of FIFO (First In First Out). The tasks that
> get to the CPU first run till they voluntarily schedule away, or are
> preempted by an even high priority task. Tasks of the same priority must
> wait till the previous task has finished.
>

Then I try to fix the violation of FIFO, my thought is like below:

---
Subject: [PATCH] sched: fix the violation of SCHED_FIFO in
check_preempt_equal_prio()

Starvation of the same priority tasks is a perfectly valid situation for
SCHED_FIFO.

If task p is currently running and is a FIFO task, you do not push it
off for another task of same prio.
Yes, that is the definition of FIFO (First In First Out). The tasks that
get to the CPU first run till they voluntarily schedule away, or are
preempted by an even high priority task. Tasks of the same priority must
wait till the previous task has finished.

Signed-off-by: Hillf Danton <dhillf@...il.com>
---

--- tip-git/include/linux/sched.h	Sat May 14 15:21:53 2011
+++ sched.h	Wed May 25 21:24:22 2011
@@ -1159,7 +1159,7 @@ struct sched_rt_entity {
 	unsigned long timeout;
 	unsigned int time_slice;
 	int nr_cpus_allowed;
-
+	struct rq *last_rq;
 	struct sched_rt_entity *back;
 #ifdef CONFIG_RT_GROUP_SCHED
 	struct sched_rt_entity	*parent;
--- tip-git/kernel/sched_rt.c	Sun May 22 20:12:01 2011
+++ sched_rt.c	Wed May 25 21:41:02 2011
@@ -933,6 +933,7 @@ static void dequeue_task_rt(struct rq *r
 {
 	struct sched_rt_entity *rt_se = &p->rt;

+	rt_se->last_rq = rq;
 	update_curr_rt(rq);
 	dequeue_rt_entity(rt_se);

@@ -1030,6 +1031,13 @@ select_task_rq_rt(struct task_struct *p,

 static void check_preempt_equal_prio(struct rq *rq, struct task_struct *p)
 {
+	if (p->rt.last_rq == rq)
+		/*
+		 * if task is not newcomer,
+		 * simply preempt current for the sake of SCHED_FIFO.
+		 */
+		goto sched;
+
 	if (rq->curr->rt.nr_cpus_allowed == 1)
 		return;

@@ -1045,6 +1053,7 @@ static void check_preempt_equal_prio(str
 	 * current and none to run 'p', so lets reschedule
 	 * to try and push current away:
 	 */
+sched:
 	requeue_task_rt(rq, p, 1);
 	resched_task(rq->curr);
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/