linux-kernel - Re: [PATCH 1/3] x86, intel: Output microcode revision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110525191321.GB14151@tassilo.jf.intel.com>
Date:	Wed, 25 May 2011 12:13:21 -0700
From:	Andi Kleen <ak@...ux.intel.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Andi Kleen <andi@...stfloor.org>, x86@...nel.org,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH 1/3] x86, intel: Output microcode revision

On Wed, May 25, 2011 at 08:59:12PM +0200, Ingo Molnar wrote:
> Look at the context diff above, it has 'cpu_index', so no, there was no
> consistent convention to follow.

Well all the CPU specific fields. Anyways I renamed it now.

> attention to that lack of means of testing? :-)
> 
> > > > -	/* see notes above for revision 1.07.  Apparent chip bug */
> > 
> > This particular code pattern has no chip bug. The CPUID is required 
> > by the documentation! So whoever wrote it didn't read the 
> > documentation. So yes I dropped that obviously bogus comment.
> 
> And you thus 'obviously' forked away the reading of the microcode 
> version into another file, with the same 'obviously wrong' comment 
> left behind in another place?

I just wrote new code with correct comments.

> > It always was documented this way.
> 
> FYI, the x86 microcode driver actually predates official public 

Are you sure you're not confusing that with the AMD driver?
AFAIK Intel was always documented.


> No, it's not a problem to add /proc/cpuinfo fields in the middle - 
> please add this new field to the logical place.

Ok.

> > 
> > Huh? There's only a single one now.
> 
> That's not actually true. With your patches applied a trivial git 
> grep shows the two places reading the microcode version:

Ok you count the re-reading. Fair enough. I guess I can remove
the comment there too.

BTW before my patches there were four places, I collapsed it down
to two if you count that.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/