linux-kernel - Re: [patch 3/6] scsi, fnic: require DMA support for Cisco FNIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTi=Jc11hO3KXWFUaX1pia-MGa2SV+A@mail.gmail.com>
Date:	Wed, 25 May 2011 12:28:33 -0700
From:	Roland Dreier <roland@...nel.org>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	David Rientjes <rientjes@...gle.com>,
	"James E.J. Bottomley" <James.Bottomley@...e.de>,
	Pekka Enberg <penberg@...nel.org>,
	Christoph Lameter <cl@...ux.com>, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Abhijeet Joglekar <abjoglek@...co.com>,
	Joe Eykholt <jeykholt@...co.com>
Subject: Re: [patch 3/6] scsi, fnic: require DMA support for Cisco FNIC

On Wed, May 25, 2011 at 1:04 AM, Christoph Hellwig <hch@...radead.org> wrote:
>> The Cisco FNIC driver requires creating a SLAB_CACHE_DMA cache, which is
>> not possible if CONFIG_ZONE_DMA is disasbled.  Avoid compiling it without
>> DMA support.
>
> And you're sure it actually needs it and isn't some sort of typo?  It
> might help to Cc the maintainer to figure that out.

Yes, almost certainly it is due to a misunderstanding of what
SLAB_CACHE_DMA means.
(fnic is a modern PCIe device that doesn't have 24-bit DMA restrictions ;)

So the correct fix would likely be to delete the SLAB_CACHE_DMA from the driver.

In any case cc'ing Cisco people as hch suggested...

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/