[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <BANLkTinOkPodwvM_x8_68Fg=xb2mSiy3aQ@mail.gmail.com>
Date: Wed, 25 May 2011 16:52:20 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Parag Warudkar <parag.lkml@...il.com>
Cc: James Bottomley <James.Bottomley@...senpartnership.com>,
Jens Axboe <jaxboe@...ionio.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
Linux SCSI List <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH] SCSI IOCTL: Check for device deletion [was Re:
__elv_add_request OOPS]
On Wed, May 25, 2011 at 4:45 PM, Parag Warudkar <parag.lkml@...il.com> wrote:
>
> So now the issue is with scsi_device refcnt?
No, I'd guess that the problem is just that __scsi_remove_device()
sets queuedata to NULL. Afaik, both sdev and the queue actually stay
around.
That said, I don't have very high opinions of some of the SCSI code.
And that's me being polite. The thing is a overcomplicated mess of
indirection and pointers back-and-forth. The refcounting is crazy
and/or impossible, since the pointers really do go back-and-forth.
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists