linux-kernel - Re: [PATCH 2/3] introduce intel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110526105527.GA27748@console-pimps.org>
Date:	Thu, 26 May 2011 11:55:39 +0100
From:	Matt Fleming <matt@...sole-pimps.org>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Zhang Rui <rui.zhang@...el.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	linux-pm <linux-pm@...ts.linux-foundation.org>, mingo@...e.hu,
	acme@...hat.com, ming.m.lin@...el.com,
	"Brown, Len" <lenb@...nel.org>
Subject: Re: [PATCH 2/3] introduce intel_rapl driver

On Thu, May 26, 2011 at 11:43:23AM +0200, Peter Zijlstra wrote:
>
> That's just wrong.. the reason you're wanting to have this timer is to
> avoid the RAPL MSRs from overflowing and you loosing offsets, right?
> 
> But the above is actually forcing the event to create samples on a
> totally unrelated time base.
> 
> RAPL should fail to create a sampling event since it doesn't have the
> capability to trigger overflow interrupts based on its events.
> 
> If you want a timer, add one, but don't do this.
> 
> If you expect you actually want to sample, use this event as part of a
> group and add a sampling event in there and use PERF_FORMAT_GROUP, Matt
> was working on patches to make perf-record capable of this.

Yep, I have some unfinished patches around here somewhere...

*rummage*

OK, they're in this repository on the perf/group-events branch,

    git://git.kernel.org/pub/scm/linux/kernel/git/mfleming/sh-2.6.git

Obviously since I last touched them in November of last year they're
more than likely not going to apply cleanly to tip, and perhaps more
importantly, I don't think I ever submitted them to LKML for review.

Rui, I'll try to look at your patch series over the weekend and get my
sampling patches into a state where they can be submitted for review
and used by the intel_rapl driver. Does that sound OK?

Or if you want to take a more proactive approach, you're welcome to
finish and submit them ;-)

--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/