linux-kernel - Re: [PATCH] drivers: video: Remove useless checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTimOkpfLSiHp0Dm+jxxtHfA3PSVG-A@mail.gmail.com>
Date:	Thu, 26 May 2011 16:31:27 +0100
From:	Maxin B John <maxin.john@...il.com>
To:	tim.gardner@...onical.com
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	airlied@...hat.com, lethal@...ux-sh.org, james@...anarts.com,
	error27@...il.com, randy.dunlap@...cle.com
Subject: Re: [PATCH] drivers: video: Remove useless checks

Hi,

> IMHO mixing signed and unsigned comparisons like this is just wrong. Its
> unnecessarily complicated and misleading, especially for a device driver.

Yes. I do agree with you.

> Its likely that the reason the fb code got into this situation is because a
> type was changed from signed to unsigned whence long ago, and nobody has
> bothered to clean it up.

Thats possible. Similar useless checks are present in other subsystems
of the kernel as well.

WBR,
Maxin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/