[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20110526.150057.165386141746439600.davem@davemloft.net>
Date: Thu, 26 May 2011 15:00:57 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: randy.dunlap@...cle.com
Cc: joe@...ches.com, mingo@...e.hu, greearb@...delatech.com,
linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
arnd@...db.de, netdev@...r.kernel.org
Subject: Re: [patch] net/core/filter.c: Fix build error
From: Randy Dunlap <randy.dunlap@...cle.com>
Date: Thu, 26 May 2011 11:57:21 -0700
> On Thu, 26 May 2011 14:38:43 -0400 (EDT) David Miller wrote:
>
>> From: Joe Perches <joe@...ches.com>
>> Date: Thu, 26 May 2011 08:31:06 -0700
>>
>> > My suggestion would be to see about again adding
>> > #include <linux/ratelimit.h> somehow
>> > back to kernel.h which commit 3fff4c42bd0a removed
>> > in 2009 because of the spinlock issues.
>> >
>> > Any suggestion on how best to fix it generically?
>>
>> I don't think we want spinlock_t's definition being sucked
>> into kernel.h's dependency food chain.
>>
>> Even if desirable, I think it'd be quite a bit of surgery,
>> too much to do at this stage.
>>
>> So for now how about we make the ratelimit warn interfaces be a true,
>> instead of a pseudo, dependency on ratelimit.h by moving those
>> definitions into ratelimit.h?
>
> Works for me. Thanks.
>
> Acked-by: Randy Dunlap <randy.dunlap@...cle.com>
Thanks for reviewing Randy, I've put this into net-2.6 and will
push it out to Linus soon.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists