linux-kernel - Re: [PATCH-v5 07/13] iscsi-target: Add iSCSI Login Negotiation + Parameter logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1306436832.5807.127.camel@haakon2.linux-iscsi.org>
Date:	Thu, 26 May 2011 12:07:12 -0700
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	James Bottomley <James.Bottomley@...senPartnership.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	Christoph Hellwig <hch@....de>, Hannes Reinecke <hare@...e.de>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	Andy Grover <agrover@...hat.com>,
	Mike Christie <michaelc@...wisc.edu>,
	Boaz Harrosh <bharrosh@...asas.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Martin Svec <martin.svec@...er.cz>
Subject: Re: [PATCH-v5 07/13] iscsi-target: Add iSCSI Login Negotiation +
	Parameter logic

On Thu, 2011-05-26 at 11:46 -0500, James Bottomley wrote:
> On Thu, 2011-05-19 at 20:37 -0700, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger <nab@...ux-iscsi.org>
> > 
> > This patch adds the princple RFC-3720 compatiable iSCSI Login
> > phase negotiation for iscsi_target_mod.  This also includes the
> > target RX/TX thread queue logic which is called directly from iSCSI
> > login associated code.
> > 
> > Signed-off-by: Nicholas A. Bellinger <nab@...ux-iscsi.org> 
> 
> I thought the upshot of the thread with Tomo was that we wouldn't be
> doing all of this in-kernel.  Where's the userspace upcall for this?
> 

The technical reasons why I want to avoid this have not changed for the
1) authentication disabled and 2) 'required-to-implement' CHAP
authentication cases.  These where discussed at the bottom of the thread
from March with Tomo-san here:

http://marc.info/?l=linux-scsi&m=130108812405710&w=2

As mentioned, I am open to adding a userspace upcall for authentication
payloads post merge in order to support the 'optional-to-implement'
authentication cases.  However, pushing the above two cases out to
userspace really does add unnecessary complexity and limitiations that I
want to avoid for the default iSCSI login cases.

It also would break existing rtslib/rtsadmin-v2 userspace code, and
require a userspace daemon be aware of the necessary initiator NodeACL
information and keep the current configuration state in sync between
kernel + userspace.  The current code avoids this type of mess all
together for the default cases, and I still only see downsides and
endless maintainability headaches and delays for going back to this type
of design for a kernel-level iscsi-target.

--nab

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/