linux-kernel - Re: [PATCH] crypto: sha1: modify sha1_update to use SHA1_BLOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110525.233411.1372538972166578285.davem@davemloft.net>
Date:	Wed, 25 May 2011 23:34:11 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	msb@...omium.org
Cc:	linux-kernel@...r.kernel.org, herbert@...dor.hengli.com.au,
	linux-crypto@...r.kernel.org
Subject: Re: [PATCH] crypto: sha1: modify sha1_update to use SHA1_BLOCK_SIZE

From: Mandeep Singh Baines <msb@...omium.org>
Date: Wed, 25 May 2011 20:11:17 -0700

> Plus some other minor cleanup.
> 
> Signed-off-by: Mandeep Singh Baines <msb@...omium.org>

The temp[] buffer is explicitly places inside the inner most
basic block so that the compiler doesn't allocate the stack
space unless that code path is taken.

Besides the use of the SHA_* macros, I think your changes
actually make the code worse.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/