linux-kernel - Re: [PATCH] Set cred->user_ns in key_replace_session

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110526203819.GA27529@mail.hallyn.com>
Date:	Thu, 26 May 2011 15:38:20 -0500
From:	"Serge E. Hallyn" <serge@...lyn.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	"Serge E. Hallyn" <serge@...lyn.com>,
	Robert Święcki <robert@...ecki.net>,
	David Howells <dhowells@...hat.com>,
	lkml <linux-kernel@...r.kernel.org>, stable@...nel.org
Subject: Re: [PATCH] Set cred->user_ns in key_replace_session_keyring

Quoting Linus Torvalds (torvalds@...ux-foundation.org):
> Shouldn't this also be "Cc: stable" for 2.6.39?
> 
> Bug introduced by commit 47a150edc2a, no?

Yup, introduced there.

Stable/whoever, should I re-send this patch separately, or does this suffice?

thanks,
-serge

>                 Linus
> 
> On Thu, May 26, 2011 at 1:25 PM, Serge E. Hallyn <serge@...lyn.com> wrote:
> > Since this cred was not created with copy_creds(), it needs to get
> > initialized.  Otherwise use of syscall(__NR_keyctl, KEYCTL_SESSION_TO_PARENT);
> > can lead to a NULL deref.  Thanks to Robert for finding this.
> >
> > Signed-off-by: Serge E. Hallyn <serge.hallyn@...onical.com>
> > Reported-by: Robert Święcki <robert@...ecki.net>
> > Cc: David Howells <dhowells@...hat.com>
> > ---
> >  security/keys/process_keys.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/security/keys/process_keys.c b/security/keys/process_keys.c
> > index 6c0480d..92a3a5d 100644
> > --- a/security/keys/process_keys.c
> > +++ b/security/keys/process_keys.c
> > @@ -847,6 +847,7 @@ void key_replace_session_keyring(void)
> >        new-> sgid      = old-> sgid;
> >        new->fsgid      = old->fsgid;
> >        new->user       = get_uid(old->user);
> > +       new->user_ns    = new->user->user_ns;
> >        new->group_info = get_group_info(old->group_info);
> >
> >        new->securebits = old->securebits;
> > --
> > 1.7.0.4
> >
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/