linux-kernel - Re: [PATCH 1/5] dmaengine: add ep93xx DMA support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTimry2+rdp=9FA-fuhJLNfkcP3Db4w@mail.gmail.com>
Date:	Fri, 27 May 2011 00:58:19 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	Mika Westerberg <mika.westerberg@....fi>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Vinod Koul <vinod.koul@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"ryan@...ewatersys.com" <ryan@...ewatersys.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	spi mailing list <spi-devel-general@...ts.sourceforge.net>
Subject: Re: [PATCH 1/5] dmaengine: add ep93xx DMA support

2011/5/26 H Hartley Sweeten <hartleys@...ionengravers.com>:

> I think the biggest hurdle with using the amba-pl022 driver is that the ep93xx
> spi peripheral does not have the registers with the pid and cid id's.  Without
> those I don't think the amba bus driver will be able to match the device to
> the driver.

This is not a problem. We have this code to dynamically create and
register a device with a specific periphid on ux500. It worked even
before my recent patches to amba's bus.c if you have only
zeroes in these registers:

struct amba_device *
dbx500_add_amba_device(const char *name, resource_size_t base,
                       int irq, void *pdata, unsigned int periphid)
{
        struct amba_device *dev;
        int ret;

        dev = kzalloc(sizeof *dev, GFP_KERNEL);
        if (!dev)
                return ERR_PTR(-ENOMEM);

        dev->dev.init_name = name;

        dev->res.start = base;
        dev->res.end = base + SZ_4K - 1;
        dev->res.flags = IORESOURCE_MEM;

        dev->dma_mask = DMA_BIT_MASK(32);
        dev->dev.coherent_dma_mask = DMA_BIT_MASK(32);

        dev->irq[0] = irq;
        dev->irq[1] = NO_IRQ;

        dev->periphid = periphid;

        dev->dev.platform_data = pdata;

        ret = amba_device_register(dev, &iomem_resource);
        if (ret) {
                kfree(dev);
                return ERR_PTR(ret);
        }

        return dev;
}

I'd recommend coming up with some clever numbering scheme
with invented vendor ID.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/