linux-kernel - Re: [PATCH 4/4] m68knommu: Fix printk() format in free_initrd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DDDD9FE.7040002@snapgear.com>
Date:	Thu, 26 May 2011 14:41:34 +1000
From:	Greg Ungerer <gerg@...pgear.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
CC:	Greg Ungerer <gerg@...inux.org>, <linux-kernel@...r.kernel.org>,
	<uclinux-dev@...inux.org>
Subject: Re: [PATCH 4/4] m68knommu: Fix printk() format in free_initrd_mem()

Hi Geert,

On 25/05/11 19:11, Geert Uytterhoeven wrote:
> arch/m68k/mm/init_no.c:123: warning: format Ã¦%dÃ† expects type Ã¦intÃ†, but argument 2 has type Ã¦long unsigned intÃ†
>
> And use pr_notice() while we're at it.
>
> Signed-off-by: Geert Uytterhoeven<geert@...ux-m68k.org>

Acked-by: Greg Ungerer <gerg@...inux.org>

Regards
Greg


> ---
>   arch/m68k/mm/init_no.c |    5 +++--
>   1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/m68k/mm/init_no.c b/arch/m68k/mm/init_no.c
> index fdbe679..50cd12c 100644
> --- a/arch/m68k/mm/init_no.c
> +++ b/arch/m68k/mm/init_no.c
> @@ -120,7 +120,8 @@ void free_initrd_mem(unsigned long start, unsigned long end)
>   		totalram_pages++;
>   		pages++;
>   	}
> -	printk (KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages * (PAGE_SIZE / 1024));
> +	pr_notice("Freeing initrd memory: %luk freed\n",
> +		  pages * (PAGE_SIZE / 1024));
>   }
>   #endif
>
> @@ -141,7 +142,7 @@ void free_initmem(void)
>   		free_page(addr);
>   		totalram_pages++;
>   	}
> -	printk(KERN_NOTICE "Freeing unused kernel memory: %ldk freed (0x%x - 0x%x)\n",
> +	pr_notice("Freeing unused kernel memory: %luk freed (0x%x - 0x%x)\n",
>   			(addr - PAGE_ALIGN((long)&__init_begin))>>  10,
>   			(int)(PAGE_ALIGN((unsigned long)(&__init_begin))),
>   			(int)(addr - PAGE_SIZE));


-- 
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@...pgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/