linux-kernel - Re: [tip:perf/urgent] perf symbols: Handle /proc/sys/kernel/kptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110527083821.GB21386@elte.hu>
Date:	Fri, 27 May 2011 10:38:21 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Arnaldo Carvalho de Melo <acme@...hat.com>
Cc:	linux-kernel@...r.kernel.org, paulus@...ba.org, hpa@...or.com,
	mingo@...hat.com, eranian@...gle.com, tzanussi@...il.com,
	penberg@...helsinki.fi, torvalds@...ux-foundation.org,
	efault@....de, peterz@...radead.org, davej@...hat.com,
	davem@...emloft.net, fweisbec@...il.com, kees.cook@...onical.com,
	tglx@...utronix.de, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:perf/urgent] perf symbols: Handle
 /proc/sys/kernel/kptr_restrict


* Arnaldo Carvalho de Melo <acme@...hat.com> wrote:

> > Had you done this you'd have immediately noticed that the individual 
> > lines are *way* too large to fit on even large terminals. Please 
> > break such messages in a much shorter fashion - we want the error 
> > messages we output to be readable even on relatively small (80col) 
> > terminals.
> 
> But it would reflow, no?

Not on all terminals. For example my terminal will just cut anything 
beyond the col limit:

 # perf report --stdio
 No kallsyms or vmlinux with build-id 122214021a666675f6e5ff97d70a85ce7139c0e7 was found
 [kernel.kallsyms] with build id 122214021a666675f6e5ff97d70a85ce7139c0e7 not found, continuing without s
 Kernel address maps (/proc/{kallsyms,modules}) were restricted, check /proc/sys/kernel/kptr_restrict bef

So we generally want to generate error messages to look good on col80 
- it should not be hard here, right?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/