[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <201105271048.00692.arnd@arndb.de>
Date: Fri, 27 May 2011 10:48:00 +0200
From: Arnd Bergmann <arnd@...db.de>
To: Shawn Guo <shawn.guo@...escale.com>
Cc: linux-arm-kernel@...ts.infradead.org,
Shawn Guo <shawn.guo@...aro.org>, linux-kernel@...r.kernel.org,
patches@...aro.org, linus.walleij@...aro.org,
grant.likely@...retlab.ca, kernel@...gutronix.de
Subject: Re: [PATCH 2/3] ARM: mxs: add gpio-mxs platform devices
On Friday 27 May 2011, Shawn Guo wrote:
> > I know it's tempting to use macros for these, but I think it obscures
> > the code a lot, especially when you use them to concatenate identifier
> > names. Why not just do:
> >
> > struct platform_device *gpios;
> > gpios = platform_device_register_simple(mxs_host_bus, "mxs-gpio-master", 0, NULL, 0);
> >
> platform_device_register_simple does not have parameter for 'parent',
> and it sets 'parent' NULL anyway.
>
Oops, my mistake. just use platform_device_register_resndata directly then.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists