linux-kernel - Problem with patch rtc: ep93xx: Initialize drvdata before registering device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <0D753D10438DA54287A00B027084269764D331A4BE@AUSP01VMBX24.collaborationhost.net>
Date:	Thu, 26 May 2011 21:06:21 -0500
From:	H Hartley Sweeten <hartleys@...ionengravers.com>
To:	"w.sang@...gutronix.de" <w.sang@...gutronix.de>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Problem with patch rtc: ep93xx: Initialize drvdata before
 registering device

Wolfram,

I think there is a problem with your patch:

commit 92d921c5def1a7b1411bc54859c0771b2cf2c08d
rtc: ep93xx: Initialize drvdata before registering device

You are calling platform_set_drvdata() with rtc == NULL at best, it
could possibly also be garbage.  The rtc variable is allocated in
rtc_device_register().

A couple printk's prove this out:

ep93xx_rtc_probe: before platform_set_drvdata -> rtc:   (null)
ep93xx-rtc ep93xx-rtc: rtc core: registered ep93xx-rtc as rtc0
ep93xx_rtc_probe: after rtc_device_register -> rtc: c4789c00

Regards,
Hartley