linux-kernel - Re: [PATCH] drm/i915: fix regression after clock gating init split

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yunaae8j5dg.fsf@aiko.keithp.com>
Date:	Fri, 27 May 2011 13:44:11 -0600
From:	Keith Packard <keithp@...thp.com>
To:	Jason Stubbs <jasonbstubbs@...il.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/i915: fix regression after clock gating init split

On Fri, 27 May 2011 23:44:19 +1000, Jason Stubbs <jasonbstubbs@...il.com> wrote:
> From: Jason Stubbs <jasonbstubbs@...il.com>
> 
> In revision 6067aaeadb5b3df26f27ac827256b1ef01e674f5, the function
> intel_enable_clock_gating is split up by device. drm_i915_display_funcs then
> gained a function pointer called init_clock_gating that intel_init_display
> sets to the appropriate function. However, there are some code paths, notably
> IS_PINEVIEW(dev), where init_clock_gating is not set and not needed. Calling
> it then fails. This patch fixes it by simply adding a null-pointer
> check.

Looks like Pineview should be using the gen3_init_clock_gating function.

-- 
keith.packard@...el.com

Content of type "application/pgp-signature" skipped