linux-kernel - RE: [PATCH 6/6] unicore32: using generic-y format for one line asm-generic files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 May 2011 11:24:03 +0800
From:	"Guan Xuetao" <gxt@...c.pku.edu.cn>
To:	"'Arnd Bergmann'" <arnd@...db.de>
Cc:	<linux-kernel@...r.kernel.org>, <linux-arch@...r.kernel.org>,
	<greg@...ah.com>, "'Sam Ravnborg'" <sam@...nborg.org>
Subject: RE: [PATCH 6/6] unicore32: using generic-y format for one line asm-generic files



> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd@...db.de]
> Sent: Thursday, May 26, 2011 8:45 PM
> To: GuanXuetao
> Cc: linux-kernel@...r.kernel.org; linux-arch@...r.kernel.org; greg@...ah.com; Sam Ravnborg
> Subject: Re: [PATCH 6/6] unicore32: using generic-y format for one line asm-generic files
> 
> On Thursday 26 May 2011, GuanXuetao wrote:
> > From: Guan Xuetao <gxt@...c.pku.edu.cn>
> >
> > see commit from Sam Ravnborg <d8ecc5cd8e227bc318513b5306ae88a474b8886d>
> >   kbuild: asm-generic support
> >
> > Signed-off-by: Guan Xuetao <gxt@...c.pku.edu.cn>
> > ---
> >  arch/unicore32/Makefile           |   35 ----------------------
> >  arch/unicore32/include/asm/Kbuild |   59 +++++++++++++++++++++++++++++++++++++
> >  2 files changed, 59 insertions(+), 35 deletions(-)
> 
> Acked-by: Arnd Bergmann <arnd@...db.de>
> 
> This reminds me that I should do the same for ARM and maybe some others.

There is a potential problem.
When I add stat.h with generic-y method, a file is generated in arch/*/include/generated/asm/ dir.
And then,  a patch for old-abi is applied, which will restore an old stat.h in arch/*/include/asm/ dir.
Without removing the line in arch/*/include/asm/Kbuild, two files exist in the meantime.
It works, depending on the order in LINUXINCLUDE, and (perhaps) the handling order in gcc.
So, a check and warning mechanism should be provided to clear up the confusion.

Guan Xuetao

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/