linux-kernel - Re: Kernel crash after using new Intel NIC (igb)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110528180434.GB12530@elte.hu>
Date:	Sat, 28 May 2011 20:04:34 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Arun Sharma <asharma@...com>, David Miller <davem@...emloft.net>,
	Maximilian Engelhardt <maxi@...monizer.de>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	StuStaNet Vorstand <vorstand@...sta.mhn.de>,
	Yann Dupont <Yann.Dupont@...v-nantes.fr>,
	Denys Fedoryshchenko <denys@...p.net.lb>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: Kernel crash after using new Intel NIC (igb)


* Eric Dumazet <eric.dumazet@...il.com> wrote:

> > +static inline int atomic_add_unless(atomic_t *v, int a, int u)
> > +{
> > +	return __atomic_add_unless(v, a, u) != u;
> >  }
> >  
> >  #define atomic_inc_not_zero(v) atomic_add_unless((v), 1, 0)
> 
> As I said, atomic_add_unless() has several implementations in 
> various arches. You must take care of all, not only x86.

It's a bit sad to see local hacks to generic facilities committed 
upstream like that.

Arun: the x86 bits look good at first sight.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/