linux-kernel - Re: [GIT PULL] sound updates #2 for 2.6.40

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTimvMKF-ULuk=B52hji3GSr=tXrWXw@mail.gmail.com>
Date:	Fri, 27 May 2011 19:44:54 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] sound updates #2 for 2.6.40

On Fri, May 27, 2011 at 7:41 PM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> Looking at that diff, I found at least one bug:
>
> -       if (chip->driver_type != AZX_DRIVER_ATI &&
> -           chip->driver_type != AZX_DRIVER_ATIHDMI)
> +       if (chip->driver_caps & AZX_DCAPS_NO_TCSEL) {
>
> That's wrong. It should be
>
>        if (!(chip->driver_caps & AZX_DCAPS_NO_TCSEL)) {
>
> but I haven't checked if that fixes it for me yet.

Yup, that's it. Apparently if you don't clear the TCSEL bit, you get
random static and repeated stuff.

And the reason the conversion was wrong is that the bit is not a
"feature" bit, it's a "lack of feature" bit, but the conversion missed
the negation.

                      Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/