linux-kernel - Re: IrDA driver fails on PXA255

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110528234614.GV24876@n2100.arm.linux.org.uk>
Date:	Sun, 29 May 2011 00:46:14 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	Nicolas Pitre <nicolas.pitre@...aro.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Eric Miao <eric.y.miao@...il.com>,
	Samuel Ortiz <samuel@...tiz.org>
Subject: Re: IrDA driver fails on PXA255

On Sat, May 28, 2011 at 04:34:07PM -0700, David Rientjes wrote:
> The driver is attempting to allocate DMA memory and you have 
> CONFIG_ZONE_DMA disabled, which is the only reason you would get this 
> warning.  If the allocation did not fail as a result of a197b59ae6e8, the 
> page allocator may return any memory in a higher zone that the driver may 
> not be expecting.  If you had never noticed a problem before, it may be 
> possible that the driver doesn't actually have any zone restrictions and 
> GFP_DMA can be removed, but this code is pretty old.  Otherwise, it'll 
> need to depend on ZONE_DMA in the Kconfig.
> 
> Let's cc Nicolas and Russell as well.

Ouch.  We're probably going to have a pile of work to do to check that
the DMA masks on all our devices are correct for the unrestricted case
then.  That's probably going to be a very _big_ patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/