linux-kernel - Re: [PATCH 1/5] dmaengine: add ep93xx DMA support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 28 May 2011 13:33:05 +0300
From:	Mika Westerberg <mika.westerberg@....fi>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"ryan@...ewatersys.com" <ryan@...ewatersys.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Dan Williams <dan.j.williams@...el.com>,
	Vinod Koul <vinod.koul@...el.com>
Subject: Re: [PATCH 1/5] dmaengine: add ep93xx DMA support

On Thu, May 26, 2011 at 08:38:41PM -0500, H Hartley Sweeten wrote:
> >  
> > +config EP93XX_DMA
> > +	bool "Cirrus Logic EP93xx DMA support"
> > +	depends on ARCH_EP93XX
> > +	select DMA_ENGINE
> > +	help
> > +	  Enable support for the Cirrus Logic EP93xx M2P/M2M DMA controller.
> > +
> >  config DMA_ENGINE
> >  	bool
> 
> The old dma-m2p support was always builtin.  Should ARCH_EP93XX select
> EP93XX_DMA to keep this, or should it be added to the ep93xx_defconfig?

There are no users for the DMA in ep93xx_defconfig so I think that it
shouldn't be selected by default. I was planning to change platform code to be
conditionally compiled, like:

arch/arm/mach-ep93xx/Makefile:

+obj-$(CONFIG_EP93XX_DMA)       += dma.o

Any objections?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/